Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull submodules recursively #351

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Pull submodules recursively #351

merged 1 commit into from
Dec 13, 2022

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Dec 13, 2022 •
edited by pull-request-badge bot
Loading

juanangp Ok: 3

Bug found, submodules inside libraries or other submodules are not updated this happens under data on axionlib
Adding --recursive after git foreach to update submodules inside submodules, note that this shouldn't change the behaviour if the submodules have not been initialized.

@lobis lobis added the bug Something isn't working label Dec 13, 2022
@jgalan jgalan self-requested a review December 13, 2022 18:24
jgalan
jgalan approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@jgalan jgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with a fresh git clone, but not with my pre-existing repository.

@jgalan jgalan merged commit cadb987 into master Dec 13, 2022
@jgalan jgalan deleted the submodule-recursive branch December 13, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobis lobis lobis approved these changes

@jgalan jgalan jgalan approved these changes

Assignees

@jgalan jgalan

@lobis lobis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanangp @jgalan @lobis