Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading root installation to root-6.26.10 #361

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Upgrading root installation to root-6.26.10 #361

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad52b65
Upgrading root installation to root-6.26.10
juanangp Jan 12, 2023
9a06283
Reverting changes on cmake params
juanangp Jan 12, 2023
3ec8a17
Merge branch 'master' into root-6.26.10
jgalan Jan 13, 2023
b050a92
Update scripts/installation/installROOT.sh
jgalan Jan 24, 2023
da8ce13
Now Garfield will pull the latest release v4.0. Also removed GARFIELD…
jgalan Jan 24, 2023
84df10d
Merge branch 'master' into root-6.26.10
jgalan Jan 24, 2023
68d1438
use 8 threads in cmake
lobis Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions scripts/installation/installROOT.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ case "${unameOut}" in
*) machine="UNKNOWN:${unameOut}"
esac

ROOT_VERSION=6.24.02
ROOT_VERSION=6.26.10
ROOT_DIR=$HOME/apps/root-$ROOT_VERSION

mkdir -p ${ROOT_DIR}
Expand All @@ -34,12 +34,11 @@ tar -xvzf $f
rm -rf source
mv root-$ROOT_VERSION source

mkdir -p ${ROOT_DIR}/build
cd ${ROOT_DIR}/build
mkdir -p ${ROOT_DIR}/root_build
cd ${ROOT_DIR}/root_build
jgalan marked this conversation as resolved.
Show resolved Hide resolved
jgalan marked this conversation as resolved.
Show resolved Hide resolved

cmake -Wno-dev -Dbuiltin_glew=ON -DCMAKE_CXX_STANDARD=17 -Dgdml=ON -DCMAKE_INSTALL_PREFIX=${ROOT_DIR}/install ../source
make -j30
make install
make -j8 install
Copy link
Member

@lobis lobis Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make -j8 install
make -j$(($(nproc) - 1)) install

I updated the option to use as many threads as cores minus 1.

Copy link
Member Author

@juanangp juanangp Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing that my computer got stuck since it is running out of resources, perhaps we can check nproc and remove some cores?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without a number it might take all the CPUs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use: cat /proc/cpuinfo | grep processor | wc -l? And take half the number of CPUs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my suggestion to use all minus 1 cores, I remember on some other project's documentation this is the recommended way, I have never seen half the number of cpu as recommended anywhere but we can also try it if this doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 12 cores in my WSL, but I already had issues using 10, so I think the safest is to go to the half of the cores.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO, cannot we do ($(nproc)/2)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, make -j8 is probably ok, perhaps even make -j4. Better to avoid problems.


cd ${CURRENT_DIR}

Expand Down