Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating validation file of PandaX-III #385

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Mar 3, 2023

jgalan Ok: 0

Due to update of TRestDetectorHitsSmearingProcess at rest-for-physics/detectorlib#72

@jgalan
Copy link
Member Author

jgalan commented Mar 3, 2023

@nkx I had to update the validation file for PandaX-III because I updated the way it is initialised the random generator inside TRestDetectorHitsSmearingProcess. I am not 100% sure of the reason why this is like that, but my guess is because now the random generator is initialised at InitProcess and there are two calls to new TRandom. Thus, the first event in the final processing chain is executed just after initialisation. In the previous version I think it was initialised inside InitFromConfigFile and thus, the test loop was executing the first random call.

@jgalan jgalan marked this pull request as ready for review March 3, 2023 10:09
@jgalan jgalan requested review from a team March 3, 2023 10:10
@lobis
Copy link
Member

lobis commented Mar 3, 2023

Perhaps these files are starting to become too big? The main framework repository is already at 105.69 MB size. This would increase the total size by ~3%.

@jgalan
Copy link
Member Author

jgalan commented Mar 4, 2023

Perhaps these files are starting to become too big? The main framework repository is already at 105.69 MB size. This would increase the total size by ~3%.

Ups, in fact I was not supposed to upload the Mb file. Only the 13kbytes one, I didn't notice, thanks! I will just push force.

@jgalan jgalan force-pushed the jgalan_smear_review2 branch from 303f5ec to df1e891 Compare March 4, 2023 10:28
@jgalan
Copy link
Member Author

jgalan commented Mar 4, 2023

Fixed! only 23Bytes now!

@jgalan jgalan requested review from juanangp and lobis March 6, 2023 19:27
@nkx111
Copy link
Member

nkx111 commented Mar 7, 2023

Looks fine to me

@nkx111 nkx111 self-requested a review March 7, 2023 10:44
@jgalan jgalan merged commit a6e0b61 into master Mar 7, 2023
@jgalan jgalan deleted the jgalan_smear_review2 branch March 7, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants