Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRestAnalysisTree::GetIntegral and GetContour methods added #387

Merged
merged 15 commits into from
Mar 29, 2023
Merged

TRestAnalysisTree::GetIntegral and GetContour methods added #387

merged 15 commits into from
Mar 29, 2023

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Mar 8, 2023 •
edited by pull-request-badge bot
Loading

jgalan Medium: 117

  • Added a method TRestAnalysisTree::GetObservableIntegral.
  • Added method TRestAnalysisTree::GetContour used to find the value of an observable at which a second observable reaches a given integral value.
  • Adding methods TRestAnalysisTree::GetMax,Min,Average,RMS that invoke the corresponding GetObservableMax,Min,Average,RMS.

@jgalan jgalan requested a review from jovoy March 8, 2023 09:04
@jgalan jgalan requested review from juanangp and lobis March 8, 2023 10:33
@jgalan jgalan marked this pull request as ready for review March 8, 2023 10:47
@jgalan
Copy link
Member Author

jgalan commented Mar 8, 2023 •
edited
Loading

I have added a level as an argument that defines where the integral will stop.

@jgalan jgalan changed the title TRestAnalysisTree::GetIntegral method added TRestAnalysisTree::GetIntegral and GetContour methods added Mar 9, 2023
@jgalan jgalan requested a review from a team March 12, 2023 09:17
@jgalan
Copy link
Member Author

jgalan commented Mar 28, 2023

Please, approve, we should not forget merging this!

@jgalan jgalan merged commit 133f2b7 into master Mar 29, 2023
@jgalan jgalan deleted the jgalan_anatree_upgrade branch March 29, 2023 20:00
This was referenced Apr 27, 2023
Open
Merged
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Merge pull request #387 from rest-for-physics/jgalan_anatree_…
0595265 
…upgrade"

This reverts commit 133f2b7, reversing
changes made to b830b9a.
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Revert "Merge pull request #387 from rest-for-physics/jgalan_…
b98bf21 
…anatree_upgrade""

This reverts commit 0595265.
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Merge pull request #387 from rest-for-physics/jgalan_anatree_…
8466544 
…upgrade"

This reverts commit 133f2b7, reversing
changes made to b830b9a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanangp juanangp juanangp approved these changes

@jovoy jovoy jovoy approved these changes

@lobis lobis lobis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgalan @lobis @jovoy @juanangp