Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New class TRestDataSetPlot to perform plots over datasets #400

Merged
merged 32 commits into from
Jun 15, 2023
Merged

New class TRestDataSetPlot to perform plots over datasets #400

merged 32 commits into from
Jun 15, 2023

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Apr 25, 2023 •
edited by pull-request-badge bot
Loading

juanangp Large: 1237

New class TRestDataSetPlot implemented which is meant to perform plots over a TRestDataSet and it is meant to replace TRestAnalysisPlot.

Summary of the changes:

  • TRestDataSetPlot metadata similar to TRestAnalysisPlot with with some minor modifications.
  • Cuts implemented using generic TRestCut
  • New method implemented to add several cuts to the same panel, histo or global cut
  • Renaming SetDataSet to SetDataFrame in TRestDataSet since the first one is misleading.
  • Moving quantity on TRestDataSet from Double_t to string since it is stored as string in the TRestRun metadata
  • Bug fix on REST_StringHelper::GetChar function since it was causing segfault

@juanangp juanangp requested review from jgalan, lobis and a team April 25, 2023 14:33
@jgalan jgalan self-requested a review May 1, 2023 18:33
@juanangp juanangp requested a review from a team May 2, 2023 07:48
juanangp and others added 4 commits May 2, 2023 12:11
@juanangp @lobis
moving to std::make_unique to avoid the use of new at the constructio…
dae65cf 
…n of the unique_ptr

Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
@juanangp @lobis
Adding const to args passed to SetObservableList
22da8f6 
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
@juanangp
Addressing review comments on github
bd685ba
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
675e23b 
for more information, see https://pre-commit.ci
@juanangp juanangp requested a review from lobis May 2, 2023 13:59
@jgalan
Copy link
Member

jgalan commented May 31, 2023

@juanangp it would be good to have a RML example. Inside the directory https://github.com/rest-for-physics/framework/tree/master/examples

@juanangp
Copy link
Member Author

@juanangp it would be good to have a RML example. Inside the directory https://github.com/rest-for-physics/framework/tree/master/examples

Done

@juanangp juanangp requested a review from a team May 31, 2023 15:01
@jgalan
Copy link
Member

jgalan commented Jun 15, 2023

@juanangp Should be merged already?

@juanangp
Copy link
Member Author

juanangp commented Jun 15, 2023 •
edited
Loading

@juanangp Should be merged already?

I would like to do further changes since I think this PR might have some conflicts with the one that you just merged #432

I hope will be ready later in the afternoon.

@juanangp juanangp merged commit 2e6f7e1 into master Jun 15, 2023
@juanangp juanangp deleted the datasetPlot branch June 15, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobis lobis lobis approved these changes

@jgalan jgalan jgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanangp @jgalan @lobis