Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating installROOT.sh #410

Merged
merged 2 commits into from
May 8, 2023
Merged

Updating installROOT.sh #410

merged 2 commits into from
May 8, 2023

Conversation

raulena333
Copy link
Contributor

@raulena333 raulena333 commented May 5, 2023

raulena333 Ok: 3

  • Fixing typo in installROOT.sh.
  • Disabling xrootd and upgrading ROOT to 6.28.02

@raulena333 raulena333 requested review from juanangp and jgalan May 5, 2023 09:23
@lobis lobis self-requested a review May 5, 2023 14:07
@lobis
Copy link
Member

lobis commented May 5, 2023

I think this is a good opportunity to discuss dropping the full compilation of root in favour of just installing the pre-compiled distribution. The latest versions (for Ubuntu 22.04 atleast) are all compiled with C++17 and all required options such as gdml. What do you think @rest-for-physics/core_dev ?

@jgalan
Copy link
Member

jgalan commented May 8, 2023

I think this is a good opportunity to discuss dropping the full compilation of root in favour of just installing the pre-compiled distribution. The latest versions (for Ubuntu 22.04 atleast) are all compiled with C++17 and all required options such as gdml. What do you think @rest-for-physics/core_dev ?

I think we could recommend the pre-installed versions. But we can still maintain this compilation script in case we need to enable other features.

@jgalan
Copy link
Member

jgalan commented May 8, 2023

The present PR is disabling xrootd and fixing a small bug with the directory name. Just approve.

@jgalan jgalan merged commit a58e58c into master May 8, 2023
@jgalan jgalan deleted the rena_root_install branch May 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants