Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying opening of TRestRun and TRestDataSet files #447

Merged
merged 10 commits into from
Jun 19, 2023

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Jun 15, 2023

juanangp Ok: 68

Simplifiying restRoot behaviour for opening TRestRun and TRestDataSet

  • Reimplementing TRestAnalysisTree, TRestEvent and metadata objects in a dedicated macro REST_LoadInputFiles.C
  • Droping support for multiple files, now only one TRestRun and/or TRestDataSet can be opened (the first one)
  • If the file is not a TRestRun or a TRestDataSet it just use default root behaviour using TRint
  • Now the flag to load macros is just --m instead of --m 1 since the latest is misleading and error prone.

…hing of TRestAnalysisTree and TRestEvent and metadata
@juanangp juanangp requested a review from jgalan June 15, 2023 18:27
@jgalan
Copy link
Member

jgalan commented Jun 16, 2023

But analysisTree, eventTree and metadata objects have been removed from the automatic instances ... I find them handy.

I agree you simplify things, but without removing functionalities.

It is not better to simplify it in #441?

@juanangp
Copy link
Member Author

But analysisTree, eventTree and metadata objects have been removed from the automatic instances ... I find them handy.

I agree you simplify things, but without removing functionalities.

It is not better to simplify it in #441?

Ok, now the opening of input files is done using a macro, I didn't implement metadata yet

@juanangp
Copy link
Member Author

But analysisTree, eventTree and metadata objects have been removed from the automatic instances ... I find them handy.
I agree you simplify things, but without removing functionalities.
It is not better to simplify it in #441?

Ok, now the opening of input files is done using a macro, I didn't implement metadata yet

Now metadata objects are also implemented, note that this PR is pointing to #441 instead of master. Please, do this merge before merging #441 in master.

@jgalan jgalan merged commit e28688a into jgalan-restRoot Jun 19, 2023
@jgalan jgalan deleted the restroot_update branch June 19, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants