Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macro to find library version from git #450

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Add macro to find library version from git #450

merged 3 commits into from
Jun 16, 2023

Conversation

lobis
Copy link
Member

@lobis lobis commented Jun 16, 2023 •
edited by pull-request-badge bot
Loading

@lobis lobis requested review from jgalan and juanangp June 16, 2023 10:12
@lobis lobis added the cmake Related to CMake label Jun 16, 2023
jgalan
jgalan reviewed Jun 16, 2023
View reviewed changes
cmake/LibraryVersion.cmake Outdated Show resolved Hide resolved
@jgalan
Copy link
Member

jgalan commented Jun 16, 2023

This PR has been merged in #451

@lobis lobis marked this pull request as ready for review June 16, 2023 10:46
@jgalan jgalan self-requested a review June 16, 2023 12:30
@jgalan jgalan merged commit aecce42 into master Jun 16, 2023
@jgalan jgalan deleted the lobis-automatic-library-version branch June 16, 2023 13:45
@jgalan jgalan mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@juanangp juanangp Awaiting requested review from juanangp

Assignees
No one assigned
Labels
cmake Related to CMake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace library version system.
2 participants
@lobis @jgalan