Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new class TRestGeant4GeometryInfo #36

Merged
merged 11 commits into from
Mar 7, 2022
Merged

Conversation

lobis
Copy link
Member

@lobis lobis commented Mar 5, 2022

Large lobis 415

New class TRestGeant4GeometryInfo used to store geometry information. Code originally from https://github.com/lobis/radiation-transport, needed to correctly work with assembly gdml geometries.

@lobis lobis requested review from jgalan and nkx111 March 5, 2022 19:29
@jgalan
Copy link
Member

jgalan commented Mar 5, 2022

I think a usage example would be desirable, including a pipeline.

@nkx111
Copy link
Member

nkx111 commented Mar 6, 2022

I think a usage example would be desirable, including a pipeline.

Would this PR change anything for the user? I guess the pipeline is not changed. May be the example could be just loading an individual gdml file with this new class?

@lobis
Copy link
Member Author

lobis commented Mar 7, 2022

I think a usage example would be desirable, including a pipeline.

Would this PR change anything for the user? I guess the pipeline is not changed. May be the example could be just loading an individual gdml file with this new class?

@jgalan

Yes, this should not change anything for the user.

It just adds a new member to TRestGeant4Metadata, GetGeant4GeometryInfo which returns a reference to the geometry info where some important information is stored, such as the name of logical, physical volumes, materials.. also some important information such as geometry volumes positions, which can later be used on analysis.

The original motivation was that the usage of assembly geometries requires a new way to define a "volume name", since the one provided by Geant4 GDML parser and ROOT differs. This class takes care of this internally, keeping the usual volume names for geometries that are not using assembly.

I also added an example to restG4 (10.Geometries) to check the correct reading of assembly geometries, but its not working due to bugs in the Geant4 10.4.3 and older versions, so the validation script doesn't throw until we upgrade Geant4 version.

@lobis lobis merged commit 7787ae5 into master Mar 7, 2022
@jgalan jgalan deleted the lobis-geometry-info branch March 7, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants