-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed activeVolume for assemblies #45
Conversation
If we change the value of the parameter name, at least it should follow the standards. The corresponding metadata member is Then, if we include the line This could simplify the parameter retrieval in that method. |
I see now that |
We should probably throw |
I use explicit loading of the parameter to support both names for the parameter. I agree that the logic might need revision |
activeVolume
definition not working properly with assemblies restG4#43Nevents
bynEvents
in RML files (Nevents
still works) for consistencygdml_file
bygdmlFile
in RML files (gdml_file
still works) for consistency