Update TRestGeant4AnalysisProcess.cxx

[glorialuzon]

I have added a string declaration in all the "SetObservableValue((string)obsName, *)". Those without weren't working properly (the corresponding observable branches were empty)

[lobis]

I have added a string declaration in all the "SetObservableValue((string)obsName, *)". Those without weren't working properly (the corresponding observable branches were empty)

Please, REMOVE this text! This is just a template to serve as a reminder.

Please, give as much detail as possible at your PR and create the simplest possible PR to facilitate reviewing.

If your PR fixes a given issue, please specify the number followed by #

Fixes #

Give a detailed list of changes proposed in this pull-request. For example:

• Feature added ...
• Upgraded class TRestXYZ to ...
• Added pipeline validation ...
• Documented ...
• Example added at ...
• Script ...

Once your PR is approved remember to increase this library version version following these instructions. Remember to have a look to our general contribution guide.

Reminder: Please, new features and upgrades should be sufficiently documented and a corresponding validation test at the pipeline should be implemented.

Reminder: Adding this to your PR description will notify members at the library_dev team: @rest-for-physics/restG4

Reminder: When writing your PR description remember to leave any necessary instructions to test the new implementation.

Reminder: to set-up the PR in the draft state when there is still work in progress, and make it ready once all pipelines have suceeded.

I don't understand why we need an explicit casting to std::string if the variable is already a std::string by construction... any idea why @jgalan @juanangp ?

[juanangp]

I don't understand why we need an explicit casting to std::string if the variable is already a std::string by construction... any idea why @jgalan @juanangp ?

As far as I understand the cast shouldn't be necessary.

I would suggest to make obsName constant --> const string obsName = ... but this shouldn't be the issue either.

[lobis]

I don't understand why we need an explicit casting to std::string if the variable is already a std::string by construction... any idea why @jgalan @juanangp ?

As far as I understand the cast shouldn't be necessary.

I would suggest to make obsName constant --> const string obsName = ... but this shouldn't be the issue either.

I updated this PR and made rest-for-physics/framework#339 to do a more correct handling of strings.

I should have no effect, but it would be nice if @glorialuzon can confirm if the problem motivating this PR exists on the branch glorialuzon-patch-1 (also update framework to glorialuzon-patch-1).