Prevent noise from going out of bounds #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
reviewed
Aug 8, 2023
src/TRestRawSignal.cxx
Outdated
| @@ -591,12 +595,14 @@ void TRestRawSignal::GetWhiteNoiseSignal(TRestRawSignal* noiseSignal, Double_t n | |||
| double* dd = new double(); | |||
| uintptr_t seed = (uintptr_t)dd + (uintptr_t)this; | |||
| delete dd; | |||
| TRandom3* fRandom = new TRandom3(seed); | |||
| TRandom3 random(seed); | |||
There was a problem hiding this comment.
Perhaps the seed should be stored inside TRestRawSignal::fSeed. It should be initialised just once, not every time GetWhiteNoiseSignal is called. This may lead to unreproducible results.
There was a problem hiding this comment.
Implemented in 9499c8e.
By default it will use the same seed as the global seed for TRandom but it can also be specified via TRestRawSignal::SetSeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113