Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new method to draw signals in TRestRawSignalEvent #46

Merged
merged 11 commits into from
Apr 26, 2022
Merged

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Jan 29, 2022

juanangp Medium: 113

Adding new method to draw a vector or signal IDs in TRestRawSignalEvent

…it returns a rawSignalEvent and mimics zero suppression from the electronics
@juanangp juanangp requested a review from a team March 18, 2022 09:11
Copy link
Member

@nkx111 nkx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the new TRestRawZeroSuppresionProcess in the lib? There is only TRestRawSignalEvent being changed

@juanangp
Copy link
Member Author

TRestRawZeroSupressionProcess has been fully removed from the code, now it is implemented under connectorslib TRestDetectorHitsToTrackProcess

Indeed, the PR is misleading, I will change the title and the description

@juanangp juanangp changed the title Moving TRestRawZeroSuppresionProcess from connectors to raw lib Adding new method to draw signals in TRestRawSignalEvent Mar 23, 2022
@jgalan
Copy link
Member

jgalan commented Apr 5, 2022

Probably the new implemented method should be used by TRestRawSignalEvent::DrawEvent under a particular option being passed?

@juanangp
Copy link
Member Author

juanangp commented Apr 8, 2022

Probably the new implemented method should be used by TRestRawSignalEvent::DrawEvent under a particular option being passed?

Now TRestRawSignalEvent::DrawEvent calls TRestRawSignalEvent::DrawSignals for the drawing of the pulses, previous functionality is kept.

@jgalan
Copy link
Member

jgalan commented Apr 8, 2022

Since you re-furbished the DrawEvent method you probably have at hand a nice plot that could be added to the TRestRawSignalEvent documentation?

I am successful adding images in doxygen with the following recipe:

/// \htmlonly <style>div.image img[src="image.png"]{width:750px;}</style> \endhtmlonly
///
/// ![A text as the title of the image](image.png)

@juanangp
Copy link
Member Author

juanangp commented Apr 8, 2022

Since you re-furbished the DrawEvent method you probably have at hand a nice plot that could be added to the TRestRawSignalEvent documentation?

I am successful adding images in doxygen with the following recipe:

/// \htmlonly <style>div.image img[src="image.png"]{width:750px;}</style> \endhtmlonly
///
/// ![A text as the title of the image](image.png)

I am not sure how to upload de image, find it below

image

@jgalan
Copy link
Member

jgalan commented Apr 8, 2022

The image must be placed at the images directory. Then, it will be found by doc/doxygen/REST.conf when executing doxygen. Just uploaded it at a0507f6.

It will be automatically compiled at night as soon as it is placed at master. And it will be rendered at https://sultan.unizar.es/rest/. For doing tests, sometimes I do it manually and place it here: https://sultan.unizar.es/test/

@juanangp juanangp merged commit 29e8b1d into master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants