-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New process TRestRawBaseLineCorrectionProcess #53
Conversation
The process is now sufficiently documented. I tested it and it works well (see the uploaded images). As shown in the previous comment, strong pulses don't distort the baseline correction anymore. |
Co-authored-by: Juan Antonio García <80903717+juanangp@users.noreply.github.com>
…cs/rawlib into BaseLineCorrectionProcess
…ecause it didn't compile
…LineCorrectionProcess
I just merged with master and pushed some commits. |
It is this PR ready to be merged? |
@jgalan Yes, it can be merged. Juanan wanted to wait for your opinion |
There are some issues rendering the documentation. I tested the compilation and found this https://sultan.unizar.es/test/classTRestRawBaseLineCorrectionProcess.html You may have a look to the following recently documented class: https://github.com/rest-for-physics/axionlib/blob/master/src/TRestAxionOptics.cxx To compile locally:
then open the file |
I fixed the documentation, as long as the compilation doesn't again introduce line breaks into the code which includes the pictures. |
Ok, now renders properly, a bit large images for my taste, but acceptable. https://sultan.unizar.es/test/classTRestRawBaseLineCorrectionProcess.html |
New process that stabilizes the baseline of TRestRawSignals. Technically it works, but the behavior is not optimal for signals with strong pulses. I will improve that and then update the documentation with plots how it changes the signals.