Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New process TRestRawBaseLineCorrectionProcess #53

Merged
merged 19 commits into from
May 23, 2022

Conversation

KonradAltenmueller
Copy link
Member

@KonradAltenmueller KonradAltenmueller commented Apr 1, 2022

KonradAltenmueller Medium: 244

New process that stabilizes the baseline of TRestRawSignals. Technically it works, but the behavior is not optimal for signals with strong pulses. I will improve that and then update the documentation with plots how it changes the signals.

@jgalan
Copy link
Member

jgalan commented Apr 1, 2022

You were 8 commits behind master

Screenshot 2022-04-01 at 16 16 05

I just merged master into your branch so that it is up-to-date

I did at source/libraries/raw

git fetch
git checkout master
git pull
git checkout BaseLineCorrectionProcess
git merge master
git push

@KonradAltenmueller
Copy link
Member Author

KonradAltenmueller commented May 12, 2022

Old TRestRawSignal::GetBaseLineSmoothed:
GetBaselineSmoothed_old

(The legend above is wrong, the smoothing is done with the standard GetSignalSmoothed-method)

New TRestRawSignal::GetBaseLineSmoothed with "EXCLUDE OUTLIERS" option:
GetBaselineSmoothed_improved

@KonradAltenmueller
Copy link
Member Author

The process is now sufficiently documented. I tested it and it works well (see the uploaded images). As shown in the previous comment, strong pulses don't distort the baseline correction anymore.

@KonradAltenmueller KonradAltenmueller requested review from cmargalejo, jgalan, juanangp and a team May 12, 2022 19:04
src/TRestRawSignal.cxx Outdated Show resolved Hide resolved
src/TRestRawSignal.cxx Outdated Show resolved Hide resolved
@juanangp
Copy link
Member

I just merged with master and pushed some commits.

@jgalan
Copy link
Member

jgalan commented May 23, 2022

It is this PR ready to be merged?

@KonradAltenmueller
Copy link
Member Author

KonradAltenmueller commented May 23, 2022

@jgalan Yes, it can be merged. Juanan wanted to wait for your opinion

@jgalan
Copy link
Member

jgalan commented May 23, 2022

There are some issues rendering the documentation. I tested the compilation and found this

https://sultan.unizar.es/test/classTRestRawBaseLineCorrectionProcess.html

You may have a look to the following recently documented class:

https://github.com/rest-for-physics/axionlib/blob/master/src/TRestAxionOptics.cxx

To compile locally:

cd doc/doxygen
doxygen REST.conf

then open the file html/index.html file with a web browser.

@KonradAltenmueller
Copy link
Member Author

I fixed the documentation, as long as the compilation doesn't again introduce line breaks into the code which includes the pictures.

@jgalan
Copy link
Member

jgalan commented May 23, 2022

Ok, now renders properly, a bit large images for my taste, but acceptable.

https://sultan.unizar.es/test/classTRestRawBaseLineCorrectionProcess.html

@KonradAltenmueller KonradAltenmueller merged commit 37b9942 into master May 23, 2022
@KonradAltenmueller KonradAltenmueller deleted the BaseLineCorrectionProcess branch May 23, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants