Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new process rawTDStoSignal #59

Merged
merged 7 commits into from
May 23, 2022
Merged

Adding new process rawTDStoSignal #59

merged 7 commits into from
May 23, 2022

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented May 10, 2022

juanangp Large: 277

New feature, new process added to transform TDS (Tektronix oscilloscope DAQ) data format (https://lfna.unizar.es/gifna/tds) into rawSignalEvent. The different oscilloscope channels are stored in consecutive channel ids from 0 to 4 if present.

@juanangp juanangp requested review from jgalan and lobis May 10, 2022 17:08
juanangp and others added 2 commits May 10, 2022 21:20
@jgalan
Copy link
Member

jgalan commented May 10, 2022

I just added an example to attempt to read a TDS file. I have created the examples directory that it will be installed under REST_PATH/examples/raw. In fact, I recently added the examples path to the default search paths, then we can just run them from anywhere. See commit rest-for-physics/framework@652fd26 at the draft PR rest-for-physics/framework#198.

So, if I compile using the branch jgalan_masks from framework, and this branch at rawlib, and I try to test as follows, I get into troubles:

jgalan@sultan:~$ restManager --c tdsAQS.rml --f /storage/iaxo/RyD/gem-mm/GEMMM0034.raw.01 
Warning in <UnknownClass::SetDisplay>: DISPLAY not set, setting it to 79.116.70.207:0.0
Starting pid: 39763
                            
              [==                                  Launching TRestManager...                                   ==]              
                            
              [==                                    Creating TRestManager                                     ==]              
              [==                                            path:.                                            ==]              
terminate called after throwing an instance of 'std::runtime_error'
  what():  popen() failed!
Aborted
jgalan@sultan:~$ 

@juanangp
Copy link
Member Author

restManager --c tdsAQS.rml --f /storage/iaxo/RyD/gem-mm/GEMMM0034.raw.01

That's weird, I have tried locally and it runs properly:
image

@jgalan
Copy link
Member

jgalan commented May 10, 2022

Ok, it also does for me now 8/

@jgalan
Copy link
Member

jgalan commented May 10, 2022

I added a fix at rest-for-physics/framework@7705190 for the retrieval of fParentRunNumber value.

@juanangp juanangp merged commit 6a01dd0 into master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants