Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on TRestRawSignalChannelActivityProcess #64

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented May 30, 2022

juanangp Ok: 1

Bug fix.

Missing replacement of RESTDebug instead of debug

Missing replacement of `RESTDebug` instead of `debug`
@juanangp juanangp requested review from jgalan and lobis May 30, 2022 09:50
@juanangp
Copy link
Member Author

@lobis @jgalan
Does someone understand why the pipeline is failing?

@jgalan
Copy link
Member

jgalan commented May 30, 2022

Something related with TRestRawVetoAnalysisProcess?

/builds/rest-for-physics/rawlib/framework/source/libraries/raw/inc/TRestRawVetoAnalysisProcess.h:77:31: error: non-virtual member function marked 'override' hides virtual member function
[297](https://gitlab.cern.ch/rest-for-physics/rawlib/-/jobs/22151626#L297)    any GetInputEvent() const override { return fSignalEvent; }

@juanangp
Copy link
Member Author

Something related with TRestRawVetoAnalysisProcess?

/builds/rest-for-physics/rawlib/framework/source/libraries/raw/inc/TRestRawVetoAnalysisProcess.h:77:31: error: non-virtual member function marked 'override' hides virtual member function
[297](https://gitlab.cern.ch/rest-for-physics/rawlib/-/jobs/22151626#L297)    any GetInputEvent() const override { return fSignalEvent; }

I don't think so, I think it is related with recent merged PR, note that master is also failing

@jgalan
Copy link
Member

jgalan commented May 30, 2022

Branch juanangp-patch-1 at rest-for-physics/framework is not synced with master.

@jgalan
Copy link
Member

jgalan commented May 30, 2022

Note that since the branch exists it will try to validate against that branch in framework. You could simply remove that branch, then it will pull master, and there will be no pipeline for framework associated to this PR.

@juanangp
Copy link
Member Author

Branch juanangp-patch-1 at rest-for-physics/framework is not synced with master.

Indeed, I think I left some juanangp-patch-1 branch in master, now is deleted. This should remind us to delete merged or staled branches....

@jgalan
Copy link
Member

jgalan commented May 30, 2022

Now just push a new juanangp-patch-1 synced with master to get a green pipeline

@jgalan jgalan merged commit 9715694 into master May 31, 2022
@jgalan jgalan deleted the juanangp-patch-1 branch May 31, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants