made periodic print thread unique_ptr

rest-for-physics · Sep 12, 2022 · 19223f3 · 19223f3
1 parent ed9b0b4
commit 19223f3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/include/SimulationManager.h b/include/SimulationManager.h
@@ -28,7 +28,7 @@ class SimulationManager {
     void WriteEvents();
     void WriteEventsAndCloseFile();
 
-    std::thread* fPeriodicPrintThread = nullptr;
+    std::unique_ptr<std::thread> fPeriodicPrintThread = nullptr;
     bool fPeriodicPrintThreadEndFlag = false;
 
    public:

diff --git a/src/SimulationManager.cxx b/src/SimulationManager.cxx
@@ -60,7 +60,7 @@ void SimulationManager::BeginOfRunAction() {
     // gives segfault in old Geant4 versions such as 10.4.3, didn't look into it
     if (GetRestMetadata()->PrintProgress() ||
         GetRestMetadata()->GetVerboseLevel() >= TRestStringOutput::REST_Verbose_Level::REST_Essential) {
-        fPeriodicPrintThread = new thread(&PeriodicPrint, this);
+        fPeriodicPrintThread = make_unique<thread>(&PeriodicPrint, this);
     }
 #endif
 }
@@ -78,7 +78,6 @@ void SimulationManager::EndOfRunAction() {
         if (fPeriodicPrintThread->joinable()) {
             fPeriodicPrintThread->join();  // need to join thread, it may block for up to 1 thread period
         }
-        delete fPeriodicPrintThread;
     }
 
     for (auto& outputManager : fOutputManagerContainer) {