Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using <filesystem> to improve prints, updating examples with new deg angular unit #46

Merged
merged 7 commits into from
May 25, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented May 23, 2022

lobis Ok: 31

Updated example with new deg unit defined in rest-for-physics/framework#221 so that examples are easier to understand.

Improved prints using the <filesystem> library which should always be available since REST requires C++17. This PR also links to stdc++fs which may be necessary if using old compiler version.

Update: this PR rest-for-physics/framework#226 links the whole framework to std++fs (needed for systems with old compiler version such as gcc 8), so we don't need to explicitly link here.

@lobis lobis added the documentation Improvements or additions to documentation label May 23, 2022
@lobis lobis requested review from jgalan and glorialuzon May 23, 2022 12:00
CMakeLists.txt Show resolved Hide resolved
@lobis lobis changed the title Updated some examples to use angular units (degrees) Using <filesystem> to improve prints, updating examples with new deg angular unit May 23, 2022
@lobis lobis changed the title Using <filesystem> to improve prints, updating examples with new deg angular unit Using <filesystem> to improve prints, updating examples with new deg angular unit May 23, 2022
@lobis lobis marked this pull request as ready for review May 23, 2022 14:05
@lobis lobis merged commit ab18992 into master May 25, 2022
@lobis lobis deleted the lobis-degree-unit branch May 25, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants