Code

Changes related to multithreading#58

Code

Merged

lobis merged 183 commits intomasterrest-for-physics/restG4:masterfrom lobis-prepare-for-multithreadingrest-for-physics/restG4:lobis-prepare-for-multithreadingCopy head branch name to clipboardSep 14, 2022

+3,205-2,093

Commits

Commits on Jun 20, 2022

• Merge remote-tracking branch 'origin/lobis-remove-process-hardcoding' into lobis-prepare-for-multithreading

  lobis

  committed
  515caee

• Merge remote-tracking branch 'origin/lobis-remove-biasing' into lobis-prepare-for-multithreading

  Show description for 29e7e6b
  lobis

  committed
  29e7e6b

• Adding constructor to TRestGeant4Event and adding to manager

  lobis

  committed
  5b0d51d

• Initialization of OutputManager

  lobis

  committed
  f8ecc76

• Added StackingAction, updated event insertion logic

  lobis

  committed
  a3c0846

• Compilation works

  lobis

  committed
  71c9cdc

• working compilation

  lobis

  committed
  4b88326

• Added stepping verbose

  lobis

  committed
  8b6fac0

• Fixed problem with stepping verbose

  lobis

  committed
  7ddf769

Commits on Jun 21, 2022

• Added SensitiveDetector class

  lobis

  committed
  afbeca1

• using size_t for numbers

  lobis

  committed
  1eca511

• Storing per process energy in TRestGeant4Event

  lobis

  committed
  d7c20f8

• Simplified installation output

  lobis

  committed
  6e1ec9a

• Merge remote-tracking branch 'origin/master' into lobis-prepare-for-multithreading

  lobis

  committed
  c2483d3

• Added subevent tag for decays, avoid counting "" as decay in validation

  lobis

  committed
  d383bf6

• reverted cmake change

  lobis

  committed
  f9e1a69

• Added missing event origin

  lobis

  committed
  2780541

• Updated reference values of example

  lobis

  committed
  a81a8fc

• Updated example ref values

  lobis

  committed
  a3932ac

• Updated reference value for decay (was counting "" as decay)

  lobis

  committed
  c8aae98

Commits on Jun 22, 2022

• Inserted correctly volume ID and hit KE

  lobis

  committed
  dbddf42

• Added variable for decay logic, no changes

  lobis

  committed
  98e80f0

• Ignoring hits not in active volume

  lobis

  committed
  317f3be

• Updated validation with new change of active volumes

  lobis

  committed
  f75cb08

• Updated validation with new change of active volumes for reference G4

  lobis

  committed
  b4583a1

• Added example 06 to examples

  lobis

  committed
  46c1e3c

Commits on Jul 4, 2022

• fix merge conflicts

  lobis

  committed
  e0a620a

• SimulationManager - inserted references in event and tracks

  lobis

  committed
  aaab4a8

Commits on Jul 6, 2022

• fix merge conflicts

  lobis

  committed
  b979cdd

• TRestGeant4PhysicsInfo - more tests

  lobis

  committed
  2213529

• TRestGeant4Event - added new members to better track subevent info, updated validations

  lobis

  committed
  474edaa

• removed metadata injection from constructors

  lobis

  committed
  95292b3

• updating decay validation to include primary decaying particle too

  lobis

  committed
  8f0269f

• fixed decay validation

  lobis

  committed
  41b01cb

• Update validation.yml

  lobis

  authored
  b57b08e

Commits on Jul 7, 2022

• using G4RunManagerFactory

  lobis

  committed
  4ef91b6

• updated MT logic

  lobis

  committed
  3c3c108

• cleaned UI command logic

  lobis

  committed
  ded49ff

• fix MT initialization

  lobis

  committed
  f9de596

• Compatibility with older versions

  lobis

  committed
  2fce679

• Multithreading example

  lobis

  committed
  1d8a5b2

• storing momentum as TVector3

  lobis

  committed
  746f3e6

• Added track length on stepping action

  lobis

  committed
  3ede16a

• TRestGeant4Track: added secondaries

  lobis

  committed
  e7d10ed

• track secondaries: Adding protection for nullptr

  lobis

  committed
  6d624c2

• fix segfault

  lobis

  committed
  f974145

• TRestGeant4Track - removed redundant track length

  lobis

  committed
  7220198

• general cleaning

  lobis

  committed
  e04bd0c

Commits on Jul 8, 2022

• Updated track secondary handling

  lobis

  committed
  8609e61

• TRestGeant4Track - renamed some members

  lobis

  committed
  24a9d2c

• Simplified primary generator

  lobis

  committed
  a218e6f

• unified some variable names

  lobis

  committed
  10c66d6

• Simplified user distribution initialization

  lobis

  committed
  1c0bed1

• Application: removed unnecessary line

  lobis

  committed
  3423472

• Application: fixing MT

  lobis

  committed
  b483ecc

• Simplified geometry saving

  lobis

  committed
  e717100

• Added 06 example to ref version

  lobis

  committed
  0e24544

• Added 06 example to ref version - updated name

  lobis

  committed
  f7bd4af

Commits on Jul 11, 2022

• SimulationManager - made rest members private and create accessors

  lobis

  committed
  d6b7d7b

Commits on Jul 12, 2022

• Application - updated geometry writing

  lobis

  committed
  8c11bb9

• uncommented example

  lobis

  committed
  309c4f9

• Added check for correct TGeoManager in file

  lobis

  committed
  f5d5a6b

Commits on Jul 13, 2022

• Merge remote-tracking branch 'origin/master' into lobis-prepare-for-multithreading

  lobis

  committed
  e951097

• DetectorConstruction.cxx - simplified paths

  lobis

  committed
  57f2fc6

• Attempt to fix segfaults on MT

  lobis

  committed
  3036730

• updates locking

  lobis

  committed
  1d9c887

Commits on Jul 18, 2022

• TRestGeant4PrimaryGeneratorInfo - updated initialization

  lobis

  committed
  ca499a0

• Simplified generator and TRestGeant4Metadata

  lobis

  committed
  6c9112b

• PrimaryGeneratorAction - addressed TODO

  lobis

  committed
  d829348

Commits on Jul 19, 2022

• DetectorConstruction - raised error when from vol not found

  lobis

  committed
  0826cca

• Starting to add formula support for angular/energy dist

  lobis

  committed
  104c933

• TRestGeant4Metadata - updated some member names

  lobis

  committed
  5793f6e

• Using random cos2 angle from formula instead of th1d

  lobis

  committed
  c72f4fb

• PrimaryGeneratorAction - implemented generator energy from formula

  lobis

  committed
  b8a3859

• Updated parameter names preserving backwards comp

  lobis

  committed
  806dee6

• EventAction - print update

  lobis

  committed
  d174326

Commits on Jul 20, 2022

• Merge branch 'lobis-prepare-for-multithreading' of https://github.com/rest-for-physics/restG4 into lobis-prepare-for-multithreading

  lobis

  committed
  32c4e53

• Fixed example 09 validation bug

  lobis

  committed
  b539981

• Updated example 06 to use average instead of one event

  lobis

  committed
  e7e7dda

• Updated examples

  lobis

  committed
  326ec12

• Updated muon validation ref values

  lobis

  committed
  af203c8

• Updated reference value for old geant4

  lobis

  committed
  0a8cf99

• Reverted angular dist to fix bug

  lobis

  committed
  7c090bf

• Application - print geometry info before run info

  lobis

  committed
  907ce01

• Added example to check generators

  lobis

  committed
  e7324b3

• Set XML version to xml version="1.0"

  lobis

  committed
  d0de8a4

• Using circle to example 12

  lobis

  committed
  d25b84b

• Working example 12 validation

  lobis

  committed
  c3555ea

• Using "formula" instead of "TH1D" in angular generator

  lobis

  committed
  ad2aed8

• Example 04 - updated validation ref values for new seed

  lobis

  committed
  8e87d06

• Added new example to github action

  lobis

  committed
  56916f2

Commits on Jul 21, 2022

• DetectorConstruction - cleaned output a bit

  lobis

  committed
  65f7bc5

• Updated formula generator logic

  lobis

  committed
  3bce9b0

• Using formula energy generator in example 12

  lobis

  committed
  eac364a

• increased tolerance on muon example

  lobis

  committed
  1692782

Commits on Jul 25, 2022

• Fixed bug on energy generator

  lobis

  committed
  964e4ad

• Added additional check for example 12

  lobis

  committed
  17b2e1c

• Added comment to example

  lobis

  committed
  35f3cd8

• Updated validation logic for example 12

  lobis

  committed
  bde868f

Commits on Jul 27, 2022

• Added -n option to restG4 to set nEvents from cli

  lobis

  committed
  7c9d3ad

• Added option for "desired events on file"

  lobis

  committed
  9a9bb2b

• fixed potential segfault

  lobis

  committed
  22f58f6

• Fixed bug in MT

  lobis

  committed
  449fbbd

• now all threads can write events (may make some simulations slower but less memory usage)

  lobis

  committed
  37ac714

• Simplified serial/MT selection

  lobis

  committed
  f10334f

• Adding parse of time expression for new option -S

  lobis

  committed
  f58d821

• working time limit to stop simulation

  lobis

  committed
  f51a4fc

• Now simulation will attempt to save into disk after stop signal (CTRL+C)

  lobis

  committed
  c199ebe

• Adding stuff to README

  lobis

  committed
  55a00cd

Commits on Jul 28, 2022

• Made invalid rml message more clear

  lobis

  committed
  f4726b7

• DetectorConstruction - simplified

  lobis

  committed
  65e6ac8

• Fixed bug in assembly geometry

  lobis

  committed
  7e97c60

• Simplified EventAction

  lobis

  committed
  5687905

• Fixed bug on assembly geometry

  lobis

  committed
  71f07a1

• -n and -N options are no longer incompatible

  lobis

  committed
  050f35e

• Improved print statements

  lobis

  committed
  1e11d2b

• Removed problematic code when using geantino

  lobis

  committed
  cc6f62c

• Fixed bug introduced for assembly geometry

  lobis

  committed
  3f7f130

Commits on Jul 29, 2022

• Fixed bug with nEvents setting from rml

  lobis

  committed
  37a3a54

• Simplified command line options

  lobis

  committed
  6337003

• fixed small bug

  lobis

  committed
  a78047d

• Added cli banner

  lobis

  committed
  3646286

• Fixed bug with G4UI_USE

  lobis

  committed
  1f070e8

• Fixed arg parsing

  lobis

  committed
  9390d6e

• Fixed bug when calling with single parameter

  lobis

  committed
  1540be0

• Updated some error messages

  lobis

  committed
  d3494b9

• Starting to support multiple sensitive volumes

  lobis

  committed
  b0b4a8e

• Updated print for DetectorConstruction

  lobis

  committed
  eefbc20

• Updated storage section tu support multiple sensitive volumes (work in progress)

  lobis

  committed
  ffb6b6f

• Fixed bug with strings in active volume check

  lobis

  committed
  a2cfc3b

• Added method to reduce number of tracks not needed for analysis

  lobis

  committed
  a642e3e

• Fixed multiple sensitive detectors not working

  lobis

  committed
  c9bbb01

Commits on Jul 30, 2022

• Fixed bad print when exiting simulation early

  lobis

  committed
  a920357

• Fixed random seed to avoid occasional pipeline failure

  lobis

  committed
  15d423d

• Handled more errors for restG4 CLI

  lobis

  committed
  40b4e1a

• Added extra option for RemoveUnwantedTracks, fixed possible issue in activating default volumes

  lobis

  committed
  2336afc

• Fixed bug with default energy range

  lobis

  committed
  bb0c2c8

Commits on Jul 31, 2022

• Allow to pass -t 0 to signal serial mode (previously it was an error)

  lobis

  committed
  98aa339

• Working on periodic print thread

  lobis

  committed
  0dcbe5a

• Updated print to periodic function

  lobis

  committed
  ff69014

• Attempt to fix segfault

  lobis

  committed
  38e968a

• Attempt to fix segfault

  lobis

  committed
  7c99e9e

• Handle null pointers

  lobis

  committed
  22e5257

• Added error message for when output path is not accessible

  lobis

  committed
  3030586

Commits on Aug 1, 2022

• merge with origin/master

  lobis

  committed
  1be9958

• Updated examples

  lobis

  committed
  7febe62

• Added validation for output file

  lobis

  committed
  6532cd8

• Extended validation to check for metadata keys

  lobis

  committed
  5d3930f

Commits on Aug 3, 2022

• Reordered prints

  lobis

  committed
  ab6f971

Commits on Aug 30, 2022

• work in progress on alternative shaping process

  lobis

  committed
  e057db3

Commits on Sep 1, 2022

• Time is now correctly stored as us instead of s

  lobis

  committed
  503ec5c

• Attempt to fix pipeline

  lobis

  committed
  5b697ff

Commits on Sep 4, 2022

• Merge remote-tracking branch 'origin/master' into lobis-prepare-for-multithreading

  lobis

  committed
  4a66b5e

Commits on Sep 5, 2022

• fixed bug with total energy not computed

  lobis

  committed
  f8fb120

• simplified RML

  lobis

  committed
  00b1533

• added example for IAXO

  lobis

  committed
  ecb5761

• added example 13 to github pipeline

  lobis

  committed
  ef5cde7

• added validation macro for new example 13

  lobis

  committed
  d6a0452

• added more checks to validation

  lobis

  committed
  5b7cb78

Commits on Sep 6, 2022

• added example 13 to tests

  lobis

  committed
  a01a0de

• correctly insert process type

  lobis

  committed
  2375268

• working on remove unwanted tracks bug

  lobis

  committed
  fbf9871

Commits on Sep 8, 2022

• fixed bad parenthesis

  lobis

  committed
  a7db119

• added check for number of tracks and hits

  lobis

  committed
  54421db

Commits on Sep 9, 2022

• Correctly update fTrackIDToTrackIndex when removing tracks

  lobis

  committed
  73b708d

• added comment

  lobis

  committed
  48d42f0

Commits on Sep 12, 2022

• SimulationManager - added back activation volumes with random chance

  lobis

  committed
  393929c

• moved code relative to Geant4Lib into separate file

  lobis

  committed
  0a0c8c5

• renamed "Desired" to "Requested"

  lobis

  committed
  ed9b0b4

• made periodic print thread unique_ptr

  lobis

  committed
  19223f3

• attempt to fix pipeline

  lobis

  committed
  d6e7c81

Commits on Sep 13, 2022

• Revert "attempt to fix pipeline"

  Show description for 483cb20
  lobis

  committed
  483cb20

• removed problematic code

  lobis

  committed
  ecd748f

• fix small mistake in print

  lobis

  committed
  1dfa1ee

• cleanup code for saving objects to file

  lobis

  committed
  0d36aa3

• .gitlab-ci.yml - update decay value

  lobis

  committed
  03c12d9

• saving geometry earlier in run

  lobis

  committed
  1d0bf69

• writing geometry with TObject::kWriteDelete flag instead of kOverwrite

  lobis

  committed
  3a83f72

• updated example 13 (IAXO) - using good geometry

  lobis

  committed
  824e949

Commits on Sep 14, 2022

• Better formatting of print

  lobis

  committed
  299b6c3

• Better formatting of print

  lobis

  committed
  23c1674

• added method for better time printing

  lobis

  committed
  6486d1b

• avoid hardcoding max int value

  lobis

  committed
  5c5a8bd