Add go example #171
Merged
Add go example #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/go/Dockerfile
Outdated
Comment on lines
1
to
14
| FROM golang:1.22-bookworm as builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY go.* ./ | ||
| RUN go mod download | ||
| COPY . ./ | ||
|
|
||
| RUN CGO_ENABLED=0 go build -v -o server | ||
|
|
||
| FROM alpine | ||
| COPY --from=builder /app/server /app/server | ||
|
|
||
| CMD ["/app/server"] |
There was a problem hiding this comment.
Maybe just use ko for docker images? https://github.com/ko-build/ko
There was a problem hiding this comment.
idk, people can use that if they want but probably a dockerfile is what people are most likely to expect in a template?
There was a problem hiding this comment.
but probably a dockerfile is what people are most likely to expect in a template?
I can't tell if they would expect a Dockerfile, I think it's sufficient to give people one way to build a container image. The reason I suggested ko is that is so much common those days, it's used even in some of the cncf build pipelines, and it's literally one command to write down in the README. But if you wanna go with the dockerfile, i'm ok with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.