Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OptimisticTransactionDB #1428

Closed
Tracked by #1870
tillrohrmann opened this issue Apr 19, 2024 · 2 comments · Fixed by #1887
Closed
Tracked by #1870

Remove OptimisticTransactionDB #1428

tillrohrmann opened this issue Apr 19, 2024 · 2 comments · Fixed by #1887
Assignees

Comments

@tillrohrmann
Copy link
Contributor

We are going to use a forked version of the rocksdb library to extend the bindings to expose more RocksDB functionality. Eventually, we will also expose the WriteBatchWithIndex which would allow us to read our own writes. Hence, we no longer need to use the OptimisticTransactionDB mode from RocksDB (right now, we actually don't require reading our own writes).

@tillrohrmann tillrohrmann self-assigned this Apr 19, 2024
@tillrohrmann
Copy link
Contributor Author

Postponed until we have WriteBatchWithIndex since we are relying on reading our own writes when applying multiple consecutive state mutations in the EffectInterpreter::pop_from_inbox.

@tillrohrmann tillrohrmann removed their assignment Jul 29, 2024
@tillrohrmann
Copy link
Contributor Author

There is an open issue for adding support for WriteBatchWithIndex to the rust-rocksdb binding rust-rocksdb/rust-rocksdb#836.

tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 23, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 23, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 24, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 24, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
@tillrohrmann tillrohrmann self-assigned this Aug 26, 2024
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 26, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Aug 26, 2024
This commit replaces the OptimisticTransactionDB with the normal DB
and using WriteBatchWithIndex instead of transactions.

This fixes restatedev#1428.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant