Add CancelInvocation and GetCallInvocationId entries. #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcholakov
approved these changes
Sep 25, 2024
| @@ -8,7 +8,7 @@ | |||
| // the Business Source License, use of this software will be governed | |||
| // by the Apache License, Version 2.0. | |||
|
|
|||
| use super::*; | |||
| use super::{fixtures, matchers, *}; | |||
| let mut test_env = TestEnv::create().await; | ||
|
|
||
| let invocation_target = InvocationTarget::mock_service(); | ||
| let invocation_id = InvocationId::mock_random(); |
There was a problem hiding this comment.
There's something I don't understand - why do the two journal entries share an invocation id?
There was a problem hiding this comment.
if you refer to the lines below here:
tx.put_journal_entry(
&invocation_id,
1,
&fixtures::background_invoke_entry(callee_1),
)
.await;
The key of the journal table is prefixed by the invocation id, which in this case is the caller invocation id. For the callee, i indeed generate a different invocation id (callee_1)
…60bf51 65560bf51 Add CancelInvocation and GetCallInvocationId entries. (restatedev#96) 0d6b476ea Update retry count comment git-subtree-dir: crates/types/service-protocol git-subtree-split: 65560bf51eb0cb2b5be6c61e0c308221afe6091e
slinkydeveloper
force-pushed
the
issues/1710
branch
from
78c0e64
to
90465e5
Compare
Implement CancelInvocationEntry and GetInvocationIdEntry
slinkydeveloper
force-pushed
the
issues/1710
branch
from
90465e5
to
a149a4a
Compare
|
Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1710 and #1687. The full train of PRs is here: #1687 (comment)