[Bifrost] GetDigest message in replicated loglets #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
changed the title
AhmedSoliman
force-pushed
the
pr2042
branch
2 times, most recently
from
a37dee8 to
e2f847c
Compare
muhamadazmy
approved these changes
Oct 9, 2024
tillrohrmann
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thanks for creating this PR @AhmedSoliman. Stellar work, as always. LGTM. +1 for merging.
Digest as a summary of offset-range presence on a certain node. A a new request message `GetDigest` is introduced to the log-server to allow an efficient scanning of a range of offsets to check which offsets reside on this server. This process will be used as part of the tail repair to determine (a) whether a record meets the replication requirements and (b) where to fetch a certain record if we need to re-replicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digest as a summary of offset-range presence on a certain node. A a new request message
GetDigestis introduced to the log-server to allow an efficient scanning of a range of offsets to check which offsets reside on this server. This process will be used as part of the tail repair to determine (a) whether a record meets the replication requirements and (b) where to fetch a certain record if we need to re-replicate.Stack created with Sapling. Best reviewed with ReviewStack.