Auto provision #2058
Auto provision #2058
Conversation
tillrohrmann
force-pushed
the
auto-provision
branch
6 times, most recently
from
c9173a5 to
03ef822
Compare
tillrohrmann
force-pushed
the
auto-provision
branch
from
03ef822 to
2ec71ed
Compare
| self.task_center.clone(), | ||
| self.metadata_store_client.clone(), | ||
| self.networking.clone(), | ||
| ) | ||
| .await?; | ||
|
|
||
| let mut logs_controller = LogsController::init( | ||
| configuration, |
There was a problem hiding this comment.
Not a blocker, but I'd have loved if we rely more on Live configuration for a more reactive experience.
There was a problem hiding this comment.
Once the LogsController depends on values in the Configuration apart from the init phase, then this sounds like a good idea.
| async fn init_partition_table(&mut self) -> anyhow::Result<()> { | ||
| let configuration = self.configuration.live_load(); | ||
|
|
||
| let partition_table = retry_on_network_error( |
There was a problem hiding this comment.
nit: Might be worth logging that we are initializing
There was a problem hiding this comment.
Yes, will add it.
| config.common.cluster_name(), | ||
| )))?; | ||
| } | ||
| // todo write bootstrap state |
There was a problem hiding this comment.
what should we expect to do here?
There was a problem hiding this comment.
This is not fully clear to me yet. It could be the initial default log provider or whether to auto provision partitions if this needs to be agreed upon.
| /// # Automatically provision number of configured partitions | ||
| /// | ||
| /// If this option is set to `false`, then one needs to manually write a partition table to | ||
| /// the metadata store. Without a partition table, the cluster will not start. | ||
| #[clap(long, global = true)] | ||
| pub auto_provision_partitions: Option<bool>, |
There was a problem hiding this comment.
I think we will need to review the ergonomics of this process but I wouldn't block merging this.
There was a problem hiding this comment.
Sounds good :-)
|
Thanks for the review @AhmedSoliman. I will address your comments and then merge this PR once GHA gives green light. |
tillrohrmann
force-pushed
the
auto-provision
branch
from
2ec71ed to
b4182b4
Compare
This also adds the auto-provision option which tells the cluster controller whether to create an intially empty partition table or a partition table with as many partitions as the configured bootstrap partitions. This fixes restatedev#2084.
tillrohrmann
force-pushed
the
auto-provision
branch
from
b4182b4 to
c4e958a
Compare
Adds a feature to disable the auto-provisioning of partitions by the cluster controller. To disable the auto-provisioning, you can set the
auto-provision-partitions = falsein the configuration or on the CLI via--auto-provision-partitions=false.This PR is based on #2053