Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bifrost] Support repair store in log-server #2075

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Bifrost] Support repair store in log-server #2075

merged 2 commits into from
Oct 15, 2024

Conversation

Copy link

github-actions bot commented Oct 14, 2024

Test Results

  5 files  ±0    5 suites  ±0   2m 47s ⏱️ -16s
 45 tests  - 1   45 ✅  - 1  0 💤 ±0  0 ❌ ±0 
114 runs   - 3  114 ✅  - 3  0 💤 ±0  0 ❌ ±0 

Results for commit 5841488. ± Comparison against base commit effda17.

This pull request removes 1 test.
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)

♻️ This comment has been updated with latest results.

This hunts for signals to tell us if there is an ongoing seal or not. It's not used as a source of truth for whether a loglet is sealed or not, but it's important to detect an externally started seal operation that the sequencer was not aware of.
@AhmedSoliman AhmedSoliman merged commit 6e0aa8f into main Oct 15, 2024
3 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2075 branch October 15, 2024 14:23
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and a nice test showing the contract the log server follows :-) LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants