backup: Fix shutdown hang when running in the background on linux #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On shutdown the backup commands waits for the terminal output goroutine to stop. However while running in the background the goroutine ignored the canceled context.
MichaelEischer
force-pushed
the
fix-backup-background-hang
branch
from
5b27d49 to
401ef92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
On Linux, during shutdown the backup commands waits for the terminal output goroutine to stop. However while running in the background that goroutine ignored the canceled context.
This PR lets the goroutine exit instead.
Was the change discussed in an issue or in the forum before?
The hang was reported in the forum https://forum.restic.net/t/restic-alpine-container-cron-hangs-epoll-pwait/3334 .
Checklist
[ ] I have added tests for all changes in this PRTested manually.[ ] I have added documentation for the changes (in the manual)changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits