Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IAuthenticator? Authenticator in usage.md #2151

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

mavaddat
Copy link
Contributor

Remove Authenticator from RestClient init to RestClientOptions in Usage docs.

Description

Update the Usage documentation so that it conforms to the latest RestSharp API regarding where to set the IAuthenticator? Authenticator.

New deprecation in RestSharp/RestClient.cs:

    [Obsolete("Use RestClientOptions.Authenticator instead")]
    public IAuthenticator? Authenticator => Options.Authenticator;

Deprecation warning CS0618: 'RestClient.Authenticator' is obsolete: 'Use RestClientOptions.Authenticator instead' in live:

CS0618: 'RestClient.Authenticator' is obsolete: 'Use RestClientOptions.Authenticator instead'

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Conform to updated API
Conform the latest API
@mavaddat
Copy link
Contributor Author

@dotnet-policy-service agree

@alexeyzimarev alexeyzimarev merged commit 5644c25 into restsharp:dev Oct 24, 2023
1 check passed
@mavaddat mavaddat deleted the patch-1 branch October 24, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants