Fix for #231 Support for LinkedIn Field-Selector Notation #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the broken .NET RFC 3986 encoding for Uri.EscapeDataString
|
I just added a test for this fix. Let me know if there is something wrong with the code. |
|
Just pulled this in. Thanks. I had to modify this a bit to be compatible with Windows Phone. It doesn't have the Uri.HexEscape method so I just hard coded a hex map. |
|
Hi Andrew, thanks for pulling the change in. I am installing the Windows Phone SDK now to make sure future pull requests do work on Windows Phone. |
|
new version on nuget coming soon. On Wednesday, May 9, 2012 at 0:19, Bert Willems wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken .NET RFC 3986 encoding for Uri.EscapeDataString, which causes the LinkedIN field selector signature generation bug.
See the following stackoverflow question about the implementation details of this fix.
http://stackoverflow.com/questions/846487/how-to-get-uri-escapedatastring-to-comply-with-rfc-3986.
I ran all the units and my own LinkedIN tests with this fix succesfully.