Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove undocumented --focussed spelling of --focused #302

Conversation

guijan
Copy link
Contributor

@guijan guijan commented May 20, 2023

Fixes a small part of #272.
Wikitionary says "focused" is the common spelling in the Commonwealth and the US: https://en.wiktionary.org/wiki/focussed although "focussed" is recognized as valid.

@N-R-K
Copy link
Collaborator

N-R-K commented May 22, 2023

This has been in scrot since 2009, 1e90918 (the commit date doesn't match up, I presume because it was manually imported to git from some other source control system).

I think I'd just leave it be and document it instead.

@guijan
Copy link
Contributor Author

guijan commented May 23, 2023

Yeah, this fork's source was imported improperly. Someone else has a fork that does have a proper history: https://github.com/dreamer/scrot
I wonder if we can steal any bug fixes from that, or if we can fix our history.

@N-R-K
Copy link
Collaborator

N-R-K commented May 24, 2023

I wonder if we can steal any bug fixes from that

Probably worth investigating. Also if that fork is actively maintained, we should maybe try to unify efforts instead (unless that fork has philosophy/goal incompatible with ours).

if we can fix our history

This will end up changing the commit hashes of pretty much the entire repository. Which will break some (a lot?) of automated setups (e.g package managers).

And even in general, a repo changing it's entire commit history overnight is incredibly suspicious from an outside perspective (especially so for package maintainers).

@N-R-K

This comment was marked as off-topic.

@N-R-K N-R-K closed this in 3de64b1 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants