Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID3D12GraphicsCommandList2 bindings #807

Open
wants to merge 2 commits into
base: 0.3
Choose a base branch
from
Open

Add ID3D12GraphicsCommandList2 bindings #807

wants to merge 2 commits into from

Conversation

filkry
Copy link

@filkry filkry commented Sep 11, 2019

filkry#8168 on Discord.

@retep998 retep998 added the waiting on review Waiting for a reviewer to review the PR label Sep 13, 2019
@DethRaid DethRaid mentioned this pull request Sep 21, 2019
Open
retep998
retep998 requested changes May 12, 2020
View reviewed changes
src/um/d3d12.rs
@@ -2294,6 +2294,24 @@ interface ID3D12GraphicsCommandList1(ID3D12GraphicsCommandList1Vtbl):
ResolveMode: D3D12_RESOLVE_MODE,
) -> (),
}}
STRUCT!{struct D3D12_WRITEBUFFERIMMEDIATE_PARAMETER {
Dest: D3D12_GPU_VIRTUAL_ADDRESS,
Value: u32,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Value: u32,
Value: UINT32,

@retep998 retep998 added waiting on author Waiting for author to update PR based on feedback and removed waiting on review Waiting for a reviewer to review the PR labels May 12, 2020
@bsekura bsekura mentioned this pull request May 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retep998 retep998 retep998 requested changes

Assignees
No one assigned
Labels
waiting on author Waiting for author to update PR based on feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filkry @retep998