Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display regressions with QT 5.9.2 #345

Closed
dhgutteridge opened this issue Nov 18, 2017 · 13 comments
Closed

Display regressions with QT 5.9.2 #345

dhgutteridge opened this issue Nov 18, 2017 · 13 comments

Comments

@dhgutteridge
Copy link

Fedora 26 and 27 recently moved to QT 5.9.2, after which ReText began exhibiting rendering issues where particular lines in a file are not visible. I have reported this bug downstream at https://bugzilla.redhat.com/show_bug.cgi?id=1514724 which contains more details including screenshots.

A sample test case is to load the file found here:
https://raw.githubusercontent.com/rpm-software-management/dnf/master/doc/command_ref.rst

Go to line 856 in the file, and then move the cursor downwards. Note that there are rows present in the file that are not displayed with QT 5.9.2, but there are no such issues with QT 5.7.1.

I imagine this may be a QT or pyqt5 issue rather than ReText, but I have no basis to provide any insight into this.

@mitya57
Copy link
Member

mitya57 commented Nov 18, 2017

Thanks for the bug report! I am not able to reproduce it myself, and so far I have no clue what could cause this.

Can you please enable line numbers in settings and attach a screenshot with them?

Also I notice that you are using Fusion style with Qt 5.7 and Adwaita-Qt with Qt 5.9. Does this bug happen if you use Fusion (you can try by passing -style fusion argument)?

@dhgutteridge
Copy link
Author

If I enable line numbers, the problem goes away. It only manifests without that option. ("-style fusion" makes no difference. Without line numbers, the lines are missing, with line numbers, they're visible.)

@dhgutteridge
Copy link
Author

Still an issue with QT 5.9.4. (BTW, if I load a file with line numbers enabled, then disable that option, there are no rendering issues after it's disabled. Closing and re-opening the same file with line numbering disabled of course still exhibits the rendering problem.)

@mitya57
Copy link
Member

mitya57 commented May 23, 2018

Does this still happen with Qt 5.10 or 5.11?

I cannot reproduce the bug yourself, and so far you are the only user who reported this…

@dhgutteridge
Copy link
Author

I can reproduce this with Qt 5.10.1. The same sample file triggers the same missing lines.

@mitya57
Copy link
Member

mitya57 commented May 24, 2018

I noticed that in https://raw.githubusercontent.com/rpm-software-management/dnf/master/doc/command_ref.rst line 856 is this:

    Package specification like: name[-[epoch:]version[-release]][.arch]. See :ref:`Specifying Packages

while on your screenshots line 856 is different. What is marked line 856 on your screenshots is line 870 for me. Did you really attach the same file you were getting an issue with?

Also does the problem persist if you leave only the problematic lines in the file? Or it only happens in a large file?

Finally, can you please attach your configuration file (~/.config/ReText project/ReText.conf)? I want to know your font settings and other things that may help to localize the problem.

@mitya57
Copy link
Member

mitya57 commented May 24, 2018

Nevermind my first question. I just realized that this is a file in Git repository and the version from November 18th is https://raw.githubusercontent.com/rpm-software-management/dnf/b3cb12d289d096efbc82bcf1eb57c31ae41a40d6/doc/command_ref.rst.

@dhgutteridge
Copy link
Author

The problem isn't reproducible with only the problematic lines in the file, nor with a slightly larger amount of text. (I worked backwards starting with a handful of lines, and progressively added more until I ended up with about fifty lines, and each test iteration didn't reproduce the issue.)

@dhgutteridge
Copy link
Author

I forgot to add, in doing this testing, I found the steps to reproduce are a little more specific than I realized before. In order to reproduce with the sample file, it must be the first file opened in a new session. If any other files are opened before it, all lines are rendered correctly. Seems strange, but I confirmed this.

@dhgutteridge
Copy link
Author

The sole content of my ReText.conf file is:

[General]
recentFileList=/home/disciple/Downloads/command_ref.rst, /home/disciple/test_frag.rst, /home/disciple/dnf-plugins-core/README.rst, /home/disciple/dnf-plugins-core/doc/versionlock.rst, /home/disciple/Brew/README.rst, /home/disciple/docbook2odf/README.md

@mitya57
Copy link
Member

mitya57 commented May 25, 2018

Oh, it looks like I am able to reproduce it!

@mitya57
Copy link
Member

mitya57 commented May 26, 2018

And there is a fix! Any chance you can test the latest version from Git master?

I want to fix one more bug (with syncscroll extension breaking code highlight), and after that there will be a new release.

@dhgutteridge
Copy link
Author

I tested the latest version from Git master, and it fixes the problem for me, thanks!

mitya57 added a commit that referenced this issue Jun 5, 2018
Otherwise we are highlighting the document twice, and the rehighlight
happens before the textbox contents are fully processed, which can lead
to document structure damage.

Fixes #345.

(cherry picked from commit aea4b65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants