Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the bottom margin for text info #334

Closed
wants to merge 1 commit into from

Conversation

xgouchet
Copy link
Contributor

This makes sure that the text info (current line, text statistics) do
not override the document's text.

Fixes #333

This makes sure that the text info (current line, text statistics) do
not override the document's text.

Fixes retext-project#333
@mitya57
Copy link
Member

mitya57 commented Oct 16, 2017

Sorry but I’m not a fan of this. My initial idea was having the info area that does not take any vertical space. It was semi-transparent and the text to the left of it was visible.

The statistics area did not play well with that design, but your change makes it even further from it.

@xgouchet
Copy link
Contributor Author

I understand your point of view. Do you see any other way to place the text statistics ? I thought maybe it could be displayed as a popup on demand (instead of having it displayed and computed all the time). What do you think?

@mitya57
Copy link
Member

mitya57 commented Oct 16, 2017

Yes, that would be better. Or maybe move the statistics area to the right (there is usually less text on the right size), and additionally add some hack for the last line in the file hack to get #333 fixed?

@mitya57 mitya57 mentioned this pull request Oct 17, 2017
@xgouchet
Copy link
Contributor Author

@mitya57 When you say move it to the right, do you imagine stacking the cursor info and stats info, or have them both on the right, one after the other ?

@mitya57
Copy link
Member

mitya57 commented Oct 17, 2017

Maybe one above the other, maybe to the left from it. No strong opinion on this.

@xgouchet
Copy link
Contributor Author

Did the one above the other on the right side in #338

@xgouchet xgouchet closed this Oct 18, 2017
@xgouchet xgouchet deleted the bottome_info branch October 18, 2017 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants