-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the date be 'sanity-checked' prior to being updated? #18
Comments
🤖 this is your friendly neighborhood build bot announcing test build 0.1.3.18.14 ("fixes #18, part 1") Install in Zotero by downloading test build 0.1.3.18.14, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
That does look an epoch date, shifted one day. The URL in the sample doesn't exhibit the problem (anymore), but I try first to convert the date to UTC, and if that's the unix epoch of 1970-01-01, I make no changes.
Nope, I never set a time in any way with this plugin. That value comes from the standard scraper.
The zotero scraper, yes.
Maybe not, but that's what the URL claims. I can see that the epoch date is unlikely, but for this, let's first see if we find samples that necessitate it.
Any live URL is going to be older than the date added/modified? Accessed I could see.
2200 is a loooooong time from now, so uninstalling the plugin would het you the same behavior ;) |
Observed behavior
On many (over 600 items in my personal Zotero library) items (example #1), the Date field is apparently set by this plugin to '1969-12-31'.
Related?
While I don't know if also caused by this plugin, I have a dozen or so items with the Date field only containing a time (e.g. '21:54:00 +0100' for this URL).
Possible solution
I don't imagine a limited number of checks would add significant overhead to the plugin? ¯\(ツ)/¯
Example - only update date if (all?) of the following are true:
(I'll try to take a look at the code myself if I can, but I wanted to make sure to share my observations before the week got away from me.)
This is a great concept for a plugin; thank you for sharing it with the world!
Cheers,
Version details
Zotero version: 6.0.26 (Windows)
Zotero Date From Last Modified plugin: 0.1.0
The text was updated successfully, but these errors were encountered: