fix: disallow . and .. for dstDir
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error message isn't going to win any beauty contests, but this does the job. If there's an easy way to compel |
The overlay code calls `RemoveAll` on existing target directories, which absolutely does not work when the target directory is the current or parent directory. Check for this when validating the config file, so it can fail-fast. Update docs to explicitly admonish people trying to do this. Fixes: Issue retr0h#228
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay code calls
RemoveAllon existing target directories, which absolutely does not work when the target directory is the current or parent directory. Check for this when validating the config file, so it can fail-fast.Update docs to explicitly admonish people trying to do this.
Fixes: Issue #228