Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, add config example #12

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

danielabrozzoni
Copy link
Contributor

No description provided.

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

contrib/config_regtest.toml Outdated Show resolved Hide resolved
contrib/config_regtest.toml Outdated Show resolved Hide resolved
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight bit more bikeshedding

contrib/config_regtest.toml Outdated Show resolved Hide resolved
contrib/config_regtest.toml Outdated Show resolved Hide resolved
contrib/config_regtest.toml Outdated Show resolved Hide resolved
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 08b85f4

@darosior darosior merged commit fc6abbb into revault:master Apr 16, 2021
darosior added a commit to revault/revaultd that referenced this pull request Apr 19, 2021
419382e Add DEMO.md, update README.md accordingly (Daniela Brozzoni)
90115e3 Add some docs in config_regtest.toml, update directory paths (Daniela Brozzoni)

Pull request description:

  This PR needs revault/cosignerd#12 merged and probably something in coordinator too :)

  Closes #149
  Closes #140

ACKs for top commit:
  edouardparis:
    ACK 419382e
  darosior:
    ACK 419382e -- only change since last review are the typo fixes

Tree-SHA512: 4f78b40eef3e02f6c82a6986c0222baeb55c9f6e8919c79afc1b338772b0fe4db383d558944a7569470d406083c1b7138ef54a8460911cb1cf48329d0cb4395f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants