WIP: Statemachine #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
In order to be able to generate all transactions Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
So we can reuse this call to gather the value of a deposit when receiving a `sig` message. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This also corrects the database helpers, which made some wrong assumptions of the message flow. We impose a very strict order, to prevent surprises. This is a symptom that we could instead adapt the protocol messages to our needs, but let's keep it flexible for now. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This is taken and adapted from revaultd. There are few hacks because we can't derive Miniscript descriptors and create the transactions in Python. A python-revault-tx (and why not a revault-net as well) would be really helpful. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
I can't manage to get the functional tests generate coverage but hey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #3
Starting to implement statemachine logic