-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP ceremony: draft specification (co-authored with Kevin Loaec) #107
Open
JSwambo
wants to merge
4
commits into
revault:master
Choose a base branch
from
JSwambo:ceremony_spec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSwambo
force-pushed
the
ceremony_spec
branch
3 times, most recently
from
October 8, 2021 18:19
91c187d
to
c1b907b
Compare
JSwambo
force-pushed
the
ceremony_spec
branch
from
October 24, 2021 10:05
c1b907b
to
d865574
Compare
JSwambo
added a commit
to JSwambo/practical-revault
that referenced
this pull request
Jan 14, 2022
Removed: The 'Keys' section was removed in favour of a more detailed spec coming with revault#107 The 'Transactions' section was removed as it duplicates transactions.md 'Acknowledgements' section removed. Should it be somewhere else in the repo? New content: Updated transaction diagram using descriptors abstraction. Discussed options for revault deployments and the infrastructure requriements. Still to do: The 'fee bumping' section was mostly removed as we are approaching it differently. New approach needs description and rationale. 'Threat model' needs updating to better reflect our current understanding. 'Further Discussion' removed as this information is mostly out-dated or duplicated.
3 tasks
JSwambo
added a commit
to JSwambo/practical-revault
that referenced
this pull request
Jan 25, 2022
Removed: The 'Keys' section was removed in favour of a more detailed spec coming with revault#107 The 'Transactions' section was removed as it duplicates transactions.md 'Acknowledgements' section removed. Should it be somewhere else in the repo? New content: Updated transaction diagram using descriptors abstraction. Discussed options for revault deployments and the infrastructure requriements. Renamed "Threat model" section to "Risk" and updated. The 'fee bumping' section was mostly removed as we are approaching it differently. 'Further Discussion' removed as this information is mostly out-dated or duplicated.
darosior
pushed a commit
to JSwambo/practical-revault
that referenced
this pull request
Feb 1, 2022
Removed: The 'Keys' section was removed in favour of a more detailed spec coming with revault#107 The 'Transactions' section was removed as it duplicates transactions.md 'Acknowledgements' section removed. Should it be somewhere else in the repo? New content: Updated transaction diagram using descriptors abstraction. Discussed options for revault deployments and the infrastructure requriements. Renamed "Threat model" section to "Risk" and updated. The 'fee bumping' section was mostly removed as we are approaching it differently. 'Further Discussion' removed as this information is mostly out-dated or duplicated.
darosior
added a commit
that referenced
this pull request
Feb 1, 2022
…tion.md 6b35b37 introduction: replace out-dated revault.pdf with introduction.md (JSwambo) Pull request description: In addition to many language clarifications and minor updates, major differences with revault.pdf are given below. Removed: The 'Keys' section was removed in favour of a more detailed spec coming with #107 The 'Transactions' section was removed as it duplicates transactions.md 'Acknowledgements' section removed. Should it be somewhere else in the repo? 'Further Discussion' removed as this information is mostly out-dated or duplicated. New content: Updated transaction diagram using descriptors abstraction. Discussed options for revault deployments and the infrastructure requriements. Still to do: - [x] The 'fee bumping' section was mostly removed as we are approaching it differently. New approach needs description and rationale. - [x] 'Threat model' needs updating to better reflect our current understanding. - [x] Update background colour for diagram to white ACKs for top commit: darosior: ACK 6b35b37 Tree-SHA512: 6bec68f498fd393dd3fb5d6d6f0769827a7e2b1de6dce0fc5c3962846baa9be6b827400f7c74eaee958823f9fcb81608a23c559052c14fa9ab633d12c13d15cb
JSwambo
force-pushed
the
ceremony_spec
branch
from
February 18, 2022 12:49
d865574
to
c86fb1e
Compare
JSwambo
force-pushed
the
ceremony_spec
branch
from
February 18, 2022 12:51
c86fb1e
to
ac869f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.