Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer: accept ip:port pairs without port (revaultd would use the default) #250

Open
darosior opened this issue Nov 2, 2021 · 3 comments
Open

Installer: accept ip:port pairs without port (revaultd would use the default) #250

darosior opened this issue Nov 2, 2021 · 3 comments
Labels
Glitch A display bug that doesn't significantly prevents the use of the software
Milestone
sprint 4 -2022

Comments

@darosior
Copy link
Member

darosior commented Nov 2, 2021

Especially since the error is saying "it's not a valid IP address" whereas it is.
@edouardparis
Copy link
Member

You mean Installer: instead of Explorer: ?

@darosior
Copy link
Member Author

darosior commented Nov 2, 2021 via email

@edouardparis edouardparis changed the title Explorer: accept ip:port pairs without port (revaultd would use the default) Installer: accept ip:port pairs without port (revaultd would use the default) Nov 2, 2021
@edouardparis edouardparis added this to the last 2021 demo milestone Nov 15, 2021
@darosior darosior removed this from the Third demo: huffle puffer milestone Dec 21, 2021
@darosior darosior added the Glitch A display bug that doesn't significantly prevents the use of the software label Dec 21, 2021
@edouardparis
Copy link
Member

2022-06-01T17:25:39,413092211+02:00

We want it that case that the installer accepts the value in the form and append the default port to it for both 'coordinator' and 'cosigner' (default port is 8383)

@Zshan0 Zshan0 mentioned this issue Jun 19, 2022
Merged
edouardparis added a commit that referenced this issue Jul 4, 2022
@edouardparis
Merge #369: Adding default port value if not provided.
7ac8b12 
a5178a3 Adding default port value if not provided. (Zshan0)

Pull request description:

  Currently, the `Installer` gives a warning:
  ```
  Invalid format for a socket address
  ```
  If the entered host address at "Coordinator information" does not contain the port. Since there exists a default port that must be used if not provided, the GUI must try using it.

  The issue was raised in #250 and this PR closes it.

ACKs for top commit:
  edouardparis:
    ACK a5178a3

Tree-SHA512: 5eadc2c308618816cfadc2e78d3a6079d77661582fa29559190822e684ad4e50bb0abea5a462fca1fab18a1b24723d6327c762f9485eaa8cbb2ffcf9333d7cb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Glitch A display bug that doesn't significantly prevents the use of the software
Projects
None yet
Milestone
sprint 4 -2022
Development

No branches or pull requests
2 participants
@edouardparis @darosior