RBF our CPFP transactions #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should rework |
This was referenced Dec 17, 2021
|
Rebased, just waiting on revault/revault_tx#119 to be merged to point at revault_tx's master |
darosior
force-pushed
the
cpfp_rbf
branch
2 times, most recently
from
d564f5f to
3ab5eba
Compare
| let derived_cpfp_descriptor = revaultd | ||
| .derived_cpfp_descriptor(my_listunspent[i].derivation_index.expect("Must be here")); | ||
| match tx.cpfp_txin(&derived_cpfp_descriptor) { | ||
| match tx.cpfp_txin(cpfp_descriptor, &revaultd.secp_ctx) { | ||
| Some(txin) => txins.push(txin), | ||
| None => { | ||
| log::error!("No CPFP txin for tx '{}'", tx.txid()); | ||
| return Ok(()); |
There was a problem hiding this comment.
Btw this deactivates the CPFP altogether if some txin is not found. Maybe we just want to avoid cpfping that specific transaction and CPFPing the others?
(Not necessarily to be fixed in this PR)
There was a problem hiding this comment.
Yeah i noted that but didn't want to address it here (it'd also (for now) not happen with a transaction we'd have created).
|
ACK ae055f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.