Drop Windows support for JSONRPC over UDS #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [[bin]] | ||
| name = "revault-cli" | ||
| path = "src/bin/cli.rs" | ||
|
|
||
| [features] | ||
| default = ["jsonrpc_server"] | ||
| jsonrpc_server = ["jsonrpc-core", "jsonrpc-derive", "mio"] |
darosior
force-pushed
the
dump_windows
branch
2 times, most recently
from
04dbc9d to
9c33683
Compare
We now have another API accessible for Windows, so we can get rid of this hack.
darosior
force-pushed
the
dump_windows
branch
2 times, most recently
from
63b8933 to
96ffca4
Compare
darosior
force-pushed
the
dump_windows
branch
from
96ffca4 to
7ce039c
Compare
|
Arf this coordinator bug is really burdensome. Let's ignore it in this PR (Windows code obviously doesn't affect the UNIX-only functional tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #353, which provides a way to access
revaultd's commands through a library API, this drops the support of our greatly hacky JSONRPC server on UDS socket for Windows >10.This also makes the JSONRPC server an optional feature (activated by default).
Fixes #339
Fixes #79
Fixes #27