Adjust defaults in java formatter #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most do not appear to change anything or very little in eclipse examples. These were defaults if creating new from java settings. One adjustment done for try with resources to split lines which IMO has always looks wrong when it wraps. 16 values mean to wrap where necessary 81 means to wrap all except first if not necessary but to also force split (ie two resources in try will be split on separte lines) 80 means to wrap all except first if not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No immediate need here. Reviewing the settings these seem reasonable and with the try with resources it fixes what has long been questioned on formatting as it prevents putting multiple resources on same line.