Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pom] Add default descriptor / helpmojo #81

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

hazendaz
Copy link
Member

Over on javaparser, noticed this ticket javaparser/javaparser#3309.

This indicated this did not work with maven plugins but we are one, so I tried to check help. Noticed we had plugin management and m2e data for same but failed to do this at all. Added it and have tested it, works as expected. Don't recall if some reason it was not here but its generally best practice to offer 'help' at very least.

@hazendaz hazendaz requested a review from ctubbsii November 25, 2023 20:49
@hazendaz
Copy link
Member Author

@ctubbsii Do you recall any reason we would have been missing this logic?

@hazendaz hazendaz self-assigned this Dec 10, 2023
@ctubbsii
Copy link
Member

@ctubbsii Do you recall any reason we would have been missing this logic?

No. Just an oversight. Probably forgot to do it in some of my other plugins also. When I first started creating Maven plugins, I couldn't find good "getting started" documentation for new plugin authors (like best practices for class names, what to put in the POM, how to use provided scope properly for Maven-provided libs, how to use the Maven logger, when to use which plugin exception, how the plugin classpath works, etc.). I'm going to roll some of this up into a revelc-plugin-parent POM and revelc-parent POM to help with all the alerts about plugin version updates from dependabot, and to put in the boilerplate plugin stuff like this, but this would be good to merge now. Thanks for addressing this deficiency!

@ctubbsii ctubbsii added this to the 1.10.0 milestone Dec 10, 2023
@ctubbsii ctubbsii merged commit 3f931dd into revelc:main Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants