Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore // Adds nimble options to validate chunking options #19

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Chore // Adds nimble options to validate chunking options #19

merged 2 commits into from
Apr 12, 2024

Conversation

stuartjohnpage
Copy link
Collaborator

Overview

  • Adds the Nimble options dependency so we can validate the options that are passed in.
  • Also, cleans up the docs a tiny bit in the main text_chunker module
  • Adds tests asserting that invalid options are rejected

grossvogel
grossvogel approved these changes Apr 12, 2024
View reviewed changes
Copy link

@grossvogel grossvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@stuartjohnpage stuartjohnpage merged commit d8a3806 into main Apr 12, 2024
1 check passed
@stuartjohnpage stuartjohnpage deleted the add_nimble_options branch April 12, 2024 17:22
@stuartjohnpage stuartjohnpage mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossvogel grossvogel grossvogel approved these changes

@pjdiiori pjdiiori pjdiiori approved these changes

@estreeper estreeper Awaiting requested review from estreeper

@quinnmccourt quinnmccourt Awaiting requested review from quinnmccourt

@Dacello Dacello Awaiting requested review from Dacello

@fmugha2 fmugha2 Awaiting requested review from fmugha2

@rgarfield11 rgarfield11 Awaiting requested review from rgarfield11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartjohnpage @grossvogel @pjdiiori