Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python splitting // adds python separators #9

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

stuartjohnpage
Copy link
Collaborator

connects to #6

Overview

  • Adds separators for python, based on Langchain as an example
  • Adds tests for python splitting
  • Adds tests for javascript splitting

@stuartjohnpage stuartjohnpage changed the title adds python separators Python splitting // adds python separators Mar 7, 2024
@stuartjohnpage stuartjohnpage self-assigned this Mar 7, 2024
Copy link
Member

@lukeledet lukeledet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

test/support/fixtures/document_fixtures/test_code.js Outdated Show resolved Hide resolved
self.inventory = {}

def add_pet(self, pet_type, quantity):
"""Adds a specified quantity of a pet type to the inventory."""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's kinda nice for our purposes that python doc blocks (or whatever they call them) are inside the methods 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it would be a pain otherwise

@stuartjohnpage stuartjohnpage merged commit ab728bb into main Mar 8, 2024
1 check passed
@stuartjohnpage stuartjohnpage deleted the 6-add-python-separators branch March 8, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants