Added LAN functionality #1735
Merged
Added LAN functionality #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revoxhere
requested changes
Jan 2, 2024
ESP_Code/Settings.h
Outdated
| @@ -14,7 +14,7 @@ extern const char RIG_IDENTIFIER[] = "None"; | |||
|
|
|||
| // Uncomment if you want to use LAN8720 | |||
| // Select correct Board in ArduinoIDE!!! Really! | |||
| #define USE_LAN | |||
| // #define USE_LAN | |||
There was a problem hiding this comment.
Good that you made it off by default, but I'd move it from general settings to somewhere lower since it's something that a minority will use
|
Just moved down below Dashboard... I think it's "Networking" too... If you don't like that, pls give me an Idea for a good position... |
revoxhere
requested changes
Jan 2, 2024
ESP_Code/ESP-Code.ino
Outdated
| @@ -78,6 +82,8 @@ namespace { | |||
| MINER_KEY | |||
| ); | |||
|
|
|||
| static bool eth_connected = false; | |||
There was a problem hiding this comment.
Shouldn't this be placed in an #ifdef USE_LAN block?
There was a problem hiding this comment.
Yes, that's true. Just give me a second.
I'm not really good at programming yet - please bear with me
revoxhere
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAN functionality added using the ETH.h library.
Works great on OLIMEX boards...