Lints

[naomijub]

• Added default lint configuration and applied some extra lints
• Reduced the area that unsafe blocks were touching
• Renamed some buttons to improve understanding.
• In game mode, inspector only show if esc is pressed, maybe we can change it to F1
  

I had to set dtolnay/rust-toolchain to version 1.73, because version 1.74 has a MIR crash on bevy-inspector

Things I plan to do (unordered):

• Study other editor components
• Add support for Rapier
• Add component become a right click event on the inspector window (or a tab)
• Make a crates folder with xpbd and prefab
• Improve component naming
• Currently when we add a new tab we split the dock region, I want them to append to the dock tab
  
• Camera view

[naomijub]

@rewin123 if you want to check the CI please refer to the PR on my repo

[rewin123]

Thanks for the huge pull request!

I've reviewed and tested the changes. And it works correct. Unsafe megablock has been destroyed, thanks ^^. The button names are really better now. I also noticed that reasonable refactoring was done in many parts of the code.

I just have a few questions. When building on rust 1.72 I get a warning: "warning: unused manifest key lints (may be supported in a future version)". It seems that lints is only available in the nightly version of rust?

LTO seems to have to be placed in the head crate of the game, as it enables optimization on all underlying crates. Maybe it should be removed from space_editor, since ideologically the editor should be attached as a subproject to the game. (Also lto destroys compile time).

Support for reaper would be great! As well as adding components by right-click (I wanted to do it originally, but I don't see how to implement it in egui).

For third-party dependencies defined via feature I've allocated an "optional" folder, and also allocated a bevy plugin "OptinalPugin" for centralized connection of "optional" third-party modules to the editor. So in "my ideal world", reaper support should be in the "optional/reaper_plugin" folder.

[naomijub]

Happy to help, I was doing my own editor when I found yours and the way you solved prefabs was way cleverer haha.

I just have a few questions. When building on rust 1.72 I get a warning: "warning: unused manifest key lints (may be supported in a future version)". It seems that lints is only available in the nightly version of rust?

It is supported in 1.74, which should have a fix for the MIR error soon, then I can update the toolchain.

Support for reaper would be great! As well as adding components by right-click (I wanted to do it originally, but I don't see how to implement it in egui).

Will do in a next PR, our editors have a very different organization, so I get a bit lost on migrating stuff. Also, I reimplemented most of the bevy libraries because I didn't want to have dependencies on them upgrading to newer bevy versions, so some of it doesnt really sync with the original work.

For third-party dependencies defined via feature I've allocated an "optional" folder, and also allocated a bevy plugin "OptinalPugin" for centralized connection of "optional" third-party modules to the editor. So in "my ideal world", reaper support should be in the "optional/reaper_plugin" folder.

That makes sense. In my ideal "rusty" world, we can export most of your plugin into a crates folder, especially prefab part, so it could become an external library. Having said that, what do you think of a structure like:
src/ <- has editor executable
crates/

• prefab <- external crate that can be published to crates.io
• editor <- everything related to editor
• shared <- things shared between prefab and editor

modules/ <- the community modules to be featured in the editor (it could be inside crates, but I think it could cause confusion to live with crates.

• xpbd
• rapier
• vx_bevy
• openxr
• etc etc

lto was me trying to fix an internal issue, we can probably configure profiles to deal with those preferences. it has some advantages in dev mode

[naomijub]

@rewin123 what is your OS? Found some issues with windows

[rewin123]

Hmm. Ok, I don't see the problem anymore, then I'll merge the pull request.

I like the proposed file structure, except that shared is a unnecessary folder. I will start to move folder struct too.

My operating system is windows, but i did not found bugs.

[naomijub]

Lets move the discussion on the file structure to an issue?

[rewin123]

Yep. I will open