Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md Update #63

Merged
merged 6 commits into from
Sep 9, 2021
Merged

README.md Update #63

merged 6 commits into from
Sep 9, 2021

Conversation

zeel-codder
Copy link
Contributor

Describe the changes you've made

Just On Function Name Problem In README.md
it should like

x.send_file("file address")

not

x.send_document("file address") 

In telegram Sample Code.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • The title of my pull request is a short description of the requested changes.

@zeel-codder zeel-codder mentioned this pull request Sep 8, 2021
@rexdivakar
Copy link
Owner

Hey @zeel-codder please replace the below token from temp.py file with {DISCORD_TOKEN} and i will approve your PR
image

@rexdivakar rexdivakar linked an issue Sep 8, 2021 that may be closed by this pull request
@rexdivakar rexdivakar added the enhancement New feature or request label Sep 8, 2021
@zeel-codder
Copy link
Contributor Author

I change it. and still working on issue #31

temp.py Outdated
@@ -3,8 +3,7 @@
import tensorflow as tf

ssl._create_default_https_context = ssl._create_unverified_context
token = 'https://discord.com/api/webhooks/771253998313144321/5FNBsAi8-exyc-3rx' \
'LOYudQdQqMdpcaCOqCh6z1IX4ledG1oGyaONeIY1HDUns6qBZhW'
token = 'https://discord.com/api/webhooks/885143691201773578/dJgoeeuYqhhCoBNC5nX5ZMBAlx05hKkXVAgSWrSUk-rPc-c7P4n0DL98yGdHwHbERnj4'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace it with token = {DISCORD_TOKEN}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like with which token 🤔.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replace line 6 with below
token = {DISCORD_TOKEN}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am asking what is DISCORD_TOKEN and form where I can find it?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a webhook from discord and I don't wanna expose my tokens anymore so I'm storing the token in the Github secrets

@zeel-codder
Copy link
Contributor Author

hi, for issue (#31) there is a problem while we make requests in API. I add the exception to handle this issue.
Before
Screenshot from 2021-09-08 19-11-10

After
Screenshot from 2021-09-08 19-11-30

Thank you 👱

temp.py Outdated
@@ -3,7 +3,8 @@
import tensorflow as tf

ssl._create_default_https_context = ssl._create_unverified_context
token = 'https://discord.com/api/webhooks/885143691201773578/dJgoeeuYqhhCoBNC5nX5ZMBAlx05hKkXVAgSWrSUk-rPc-c7P4n0DL98yGdHwHbERnj4'
token = 'https://discord.com/api/webhooks/771253998313144321/5FNBsAi8-exyc-3rx' \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this as requested

@SanchitJain123
Copy link
Collaborator

Great 👍

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 9, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.57%.

Quality metrics Before After Change
Complexity 1.07 ⭐ 1.60 ⭐ 0.53 👎
Method Length 38.43 ⭐ 42.79 ⭐ 4.36 👎
Working memory 6.46 🙂 6.44 🙂 -0.02 👍
Quality 83.29% 81.72% -1.57% 👎
Other metrics Before After Change
Lines 179 194 15
Changed files Quality Before Quality After Quality Change
temp.py 80.58% ⭐ 80.84% ⭐ 0.26% 👍
notifly/telegram.py 84.23% ⭐ 82.00% ⭐ -2.23% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@rexdivakar rexdivakar merged commit 8aae2b3 into rexdivakar:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connectivity Bug
3 participants