-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new component folder and update pages utilities types #194
base: main
Are you sure you want to change the base?
Conversation
export type ReachableItem = RoadizNodesSources | ||
export type ReachableItemMerged = Partial<UnionToIntersection<ReachableItem>> | ||
export type PageComponentProps<T = ReachableItem> = { | ||
item: T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
sounds really linked to RoadizWalker
for me. Outside of this context, it seems not understandable. IMO we should keep entity
(instead of item
) because it refers to an abstract concept of Roadiz.
@@ -54,14 +53,14 @@ useHead({ | |||
const blocks = computed(() => (webResponse?.blocks && getBlockCollection(webResponse.blocks)) || []) | |||
|
|||
// Get default page entity | |||
const defaultPageEntity = computed(() => item && isPageEntity(item) && item) | |||
const pageItem = computed(() => item && item as AppPageItem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
should not be typed by default?
No description provided.