Added a fail through check for the project ID

[rfennell]

What problem does this PR address?

After merging #pr937 it was found that the process of getting WI/CS details could fail due to a missing project ID.

Code has been added to try two locations for the projects ID

• The originally used property
• If this is null then it falls back to the extracting the value from the JSON

Also in the process of debuging this add a bit more logging

[LouisSung]

Thank you for the detailed testing and quick check :D

I also review the change, doesn’t it look weird? Why using the && here? :o
Is the blue one correct? Or miss typed in?

[rfennell]

It is a

item to null check && if not null value || if null value

Is there a shorter syntax?

I know enough Node to be dangerous :)

[LouisSung]

Oh you mean the ternary operator? falsyableItem ? truthy : falsy?
It’s different from falsyableItem || fallbackItem

[rfennell]

Oops I got it from Stackoverflow, and confused two forms. I will tidy that and rebuild

[LouisSung]

undefined && undefined || value === (undefined && undefined) || value === undefined || value
Since logic AND (&&) has higher priority comparing to logic OR (||), ref Operator Precedence
It still works but kind of duplicated

[rfennell]

Thanks for the guidance, I will make the before I release the update

[LouisSung]

I think the xxx || yyy is better than xxx ? xxx : yyy in this situation since the former one is used for fallback and therefore is more readable and correct for the semantic point of view :)

Actually the better choice for null check is Nullish Coalescing (??) introduced in TypeScript 3.7 (this extension is using 3.6 though)
However, I think the || SHOULD be used here because you’d also want to fallback empty string but not just null/undefined