-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shakespeare data #748
add shakespeare data #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'll confirm when I get back to my laptop, but this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple updates to the alt text. Try to think of the alt text as replacing the images, rather than describing the images. That helps me write something a little more descriptive. I'll commit these changes then run the script to see if anything else needs tweaking!
/assign shakespeare-data 2024-09-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the script (evidently) cares about line-endings! I'll hack this one in to get it to work, then see why the script cares and fix it for the future. Thanks for helping to debug!
/assign shakespeare-data 2024-09-17 |
/assign shakespeare-data 2024-09-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.
Usability:
Preparation:
cleaning.R
has code to download and clean the dataset, resulting in descriptively-named data.frames.saving.R
to createcsv
s andmd
data dictionaries for each of my data.frames.{dataset}.md
files.intro.md
file to introduce my dataset.png
file.meta.yaml
, including descriptive alt text for each image.meta.yaml
about how to credit me, and deleted any parts of that block that I do not want you to use.