Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shakespeare data #748

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

nrennie
Copy link
Contributor

@nrennie nrennie commented Sep 15, 2024

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'll confirm when I get back to my laptop, but this looks great!

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple updates to the alt text. Try to think of the alt text as replacing the images, rather than describing the images. That helps me write something a little more descriptive. I'll commit these changes then run the script to see if anything else needs tweaking!

data/curated/shakespeare-data/meta.yaml Outdated Show resolved Hide resolved
data/curated/shakespeare-data/meta.yaml Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

/assign shakespeare-data 2024-09-17

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the script (evidently) cares about line-endings! I'll hack this one in to get it to work, then see why the script cares and fix it for the future. Thanks for helping to debug!

data/curated/shakespeare-data/intro.md Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

/assign shakespeare-data 2024-09-17

@jonthegeek
Copy link
Collaborator

/assign shakespeare-data 2024-09-17

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonthegeek jonthegeek merged commit 9acbb88 into rfordatascience:master Sep 16, 2024
@jonthegeek jonthegeek mentioned this pull request Sep 16, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants